Skip to content

Update Taskfile.yml #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Taskfile.yml #2484

wants to merge 1 commit into from

Conversation

tyeth
Copy link

@tyeth tyeth commented Jan 2, 2024

Address #2483 in single place

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fix for CI

What is the current behavior?

Releases are created with incorrect name according to new release tags using v prefix for version number

What is the new behavior?

v is prefixed to the version returned by Go, used later in other CI steps.

Does this PR introduce a breaking change, and is titled accordingly?

No

No

Other information

Address arduino#2483 in single place
@CLAassistant
Copy link

CLAassistant commented Jan 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0dbd871) 68.83% compared to head (2c9e4ba) 68.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2484      +/-   ##
==========================================
+ Coverage   68.83%   68.85%   +0.01%     
==========================================
  Files         204      204              
  Lines       20465    20465              
==========================================
+ Hits        14088    14091       +3     
+ Misses       5222     5220       -2     
+ Partials     1155     1154       -1     
Flag Coverage Δ
unit 68.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Jan 3, 2024
@alessio-perugini
Copy link
Contributor

@tyeth Sorry about that, we actually wanted to have the name without the v prefix in the assets name for backward compatibility reasons. Unfortunately, we had a bug in the install.sh that didn't correctly trim.
Fixed by #2485

@per1234 per1234 added conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure labels Jan 3, 2024
@tyeth tyeth deleted the patch-2 branch January 3, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: invalid Issue/PR not valid topic: infrastructure Related to project infrastructure type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants